[PATCH] D125780: [llvm-debuginfo-analyzer] 05 - Select elements
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 30 07:32:40 PDT 2022
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM, with just a few remaining nits about `public:`
================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVLine.h:88
+
public:
void print(raw_ostream &OS, bool Full = true) const override;
----------------
Repeated `public:`
================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVReader.h:168
public:
void print(raw_ostream &OS) const;
----------------
Here and above, more duplicate `public:`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125780/new/
https://reviews.llvm.org/D125780
More information about the llvm-commits
mailing list