[PATCH] D134953: [AMDGPU][GISel] Add Identity BUILD_VECTOR Combines

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCombine.td:48
 
+def trunc_buildvector_fold : GICombineRule<
+  (defs root:$op, register_matchinfo:$matchinfo),
----------------
Pierre-vh wrote:
> arsenm wrote:
> > Left behind AMDGPU copy
> That's another combine for `(G_TRUNC (G_BITCAST (G_BUILD_VECTOR x, y)`, unless that one can also go in the generic combiner?
Yes, all of this can. It's not doing anything that target specific and uses no custom opcodes 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134953/new/

https://reviews.llvm.org/D134953