[PATCH] D130718: [compiler-rt] [builtins] Detect _Float16 support at compile time

Fri Sep 30 05:59:41 PDT 2022

pengfei requested changes to this revision.
pengfei added a comment.
This revision now requires changes to proceed.

In D130718#3826529 <https://reviews.llvm.org/D130718#3826529>, @jwakely wrote:

> In D130718#3688875 <https://reviews.llvm.org/D130718#3688875>, @dim wrote:
>
>> The problem that x86_64 builds fail by default on non-gcc compilers still stands.
>
> It fails for GCC too. `cc -m32` does not set `-msse2` by default in vanilla GCC, see https://discourse.llvm.org/t/how-to-build-compiler-rt-for-new-x86-half-float-abi/63366/20?u=jwakely

Thanks for the information! Then I believe the right way is to always pass `-m32 -msse2` together when using the type.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130718/new/

https://reviews.llvm.org/D130718