[PATCH] D134083: [IVDescriptors] Before moving an instruction in SinkAfter checking if it is target of other instructions

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 01:59:57 PDT 2022


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/Transforms/LoopVectorize/first-order-recurrence-chains.ll:644
+define void @test_crash(ptr %p) {
+; CHECK-LABEL: @test_crash
+; CHECK:       ret
----------------
Please use `; CHECK-NOT: vector.body:`  to make sure this isn't vectorized


================
Comment at: llvm/test/Transforms/LoopVectorize/first-order-recurrence-chains.ll:666
+}
+
----------------
nit: stray new line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134083/new/

https://reviews.llvm.org/D134083



More information about the llvm-commits mailing list