[PATCH] D134641: [AMDGPU][Backend] Fix user-after-free in AMDGPUReleaseVGPRs::isLastVGPRUseVMEMStore

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez marked 4 inline comments as done.
jmmartinez added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUReleaseVGPRs.cpp:77
+        auto LastUseIsVMEMStore = BlockVMEMStore[MBB->getNumber()];
+        LastUseIsVMEMStore = LastUseIsVMEMStore ||
+                             any_of(MBB->predecessors(),
----------------
jmmartinez wrote:
> arsenm wrote:
> > This looks like a dead variable?
> Addressed in the previous comment, since it's not a reference it's not dead. But it surely looks confusing.
Bad phrasing: reference->value : Since it's not a //value //, but a reference, it's not dead. But it surely looks confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134641/new/

https://reviews.llvm.org/D134641