[PATCH] D131830: Clang Support for taskwait nowait clause

Thu Sep 29 23:31:12 PDT 2022

koops added a comment.

In the latest revision that was submitted the following changes were made:

================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1421
+  /// Methods for OpenMPVer
+  int getOpenMPVer() { return OpenMPVer; }
+
----------------
ABataev wrote:
> int getOpenMPVersion() const {return OpenMPVersion; }
> Plus, do you really need an OpenMP version check here? Just call the new function always
The new function __kmpc_omp_taskwait_deps_51, in openmp/runtime/src/kmp_taskdeps.cpp, is a placeholder for taking into account "nowait" clause from Spec 5.1. The scheduling of tasks might change during runtime due to "nowait" clause. Hence a check for OpenMP version is needed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131830/new/

https://reviews.llvm.org/D131830