[PATCH] D134798: [LoongArch] Do not assert value type in isFPImmLegal

Gong LingQin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 29 19:31:27 PDT 2022


gonglingqin added a comment.

In D134798#3825938 <https://reviews.llvm.org/D134798#3825938>, @SixWeining wrote:

> In D134798#3825920 <https://reviews.llvm.org/D134798#3825920>, @gonglingqin wrote:
>
>> In D134798#3825899 <https://reviews.llvm.org/D134798#3825899>, @SixWeining wrote:
>>
>>> This also makes CodeGen/PowerPC/2007-11-19-VectorSplitting.ll pass, right? So, the summary is not exact.
>>
>> Yes, I will update the summary.
>
> Better make it clear that the fix is for a LoongArch native build because on other machines these 2 tests are OK.
>
> So it could be `This patch fixes the failure of llvm/test/CodeGen/Generic/vector.ll and CodeGen/PowerPC/2007-11-19-VectorSplitting.ll for a LoongArch native build.`

OK, I will update the summary


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134798/new/

https://reviews.llvm.org/D134798



More information about the llvm-commits mailing list