[PATCH] D134606: [LAA] Change to function analysis for new PM.
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 29 15:45:39 PDT 2022
asbirlea added a comment.
Missed sending this earlier - thanks Arthur for figuring out why things weren't invalidated. I think that makes sense to fix anyway. Still think it makes sense to have LAA as function analysis, but also fix the invalidation.
----
Based on the usages I see, making LoopAccessAnalysis a function pass makes sense, but I'm missing why this is not invalidated after the loop passes.
Nit: remove unused include in LoopIdiomRecognize.cpp.
================
Comment at: llvm/include/llvm/Analysis/LoopAccessAnalysis.h:766
+class LoopAccessInfoManager {
+ /// The cache.
----------------
With this addition, could you drop the function pointer passed in all the passes and update the APIs to take `LAIs` instead? And call getInfo() internally when doing the processing on loops?
I know it means more changes, but I think the cleanup makes sense (unless I'm missing something). Ok to do as follow up NFC.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134606/new/
https://reviews.llvm.org/D134606
More information about the llvm-commits
mailing list