[PATCH] D109241: GlobalISel: Artifact combine build-vectors and unmerge into unmerge

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:1118
+
+      // Total size of elements in Unmerge before FirstElt has to be N x DstTy.
+      unsigned NumBitsBeforeFirstElt =
----------------
foad wrote:
> Wouldn't it be simpler to check that FirstEltIdx is a multiple of DstTy.getNumElements()?
Should be the same unless this is going to handle the pointer casting (or future FP types)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109241/new/

https://reviews.llvm.org/D109241