[PATCH] D117655: Precommit for build vector patches

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.
Herald added a subscriber: wdng.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/add.vni16.ll:2-3
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -global-isel -mtriple=amdgcn-amd-amdpal -mcpu=fiji < %s | FileCheck -check-prefix=GFX8 %s
+; RUN: llc -global-isel -mtriple=amdgcn-amd-amdpal -mcpu=gfx900 < %s | FileCheck -check-prefix=GFX9 %s
+
----------------
Should add a common prefix


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/add.vni16.ll:961
+
+define <11 x i16> @addv11i16arg(<11 x i16> %a, <11 x i16> %b) {
+; GFX8-LABEL: addv11i16arg:
----------------
I'd somewhat prefer to add _s to separate words in the name


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117655/new/

https://reviews.llvm.org/D117655