[PATCH] D134739: [SCEVExpander] Check expr is available for traversed InsterPts.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 29 12:00:43 PDT 2022
efriedma added a comment.
LGTM with one minor comment
================
Comment at: llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp:2510
-Value *SCEVExpander::fixupLCSSAFormFor(Instruction *User, unsigned OpIdx) {
- assert(PreserveLCSSA);
- SmallVector<Instruction *, 1> ToUpdate;
-
- auto *OpV = User->getOperand(OpIdx);
- auto *OpI = dyn_cast<Instruction>(OpV);
- if (!OpI)
- return OpV;
+Value *SCEVExpander::fixupLCSSAFormFor(Value *V, const SCEV *SH) {
+ auto *DefI = dyn_cast<Instruction>(V);
----------------
"SH" is unused?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134739/new/
https://reviews.llvm.org/D134739
More information about the llvm-commits
mailing list