[PATCH] D134896: [MC] Properly disable debug-frame test on AppleSilicon Mac

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 29 11:15:06 PDT 2022


steven_wu created this revision.
steven_wu added reviewers: thakis, aprantl.
Herald added subscribers: ributzka, emaste.
Herald added a project: All.
steven_wu requested review of this revision.
Herald added a subscriber: MaskRay.
Herald added a project: LLVM.

Disable debug-frame tests on AppleSilicon Mac to improve some of the fix
in PR46647.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134896

Files:
  llvm/test/MC/ELF/cfi-version.ll
  llvm/test/lit.cfg.py


Index: llvm/test/lit.cfg.py
===================================================================
--- llvm/test/lit.cfg.py
+++ llvm/test/lit.cfg.py
@@ -436,8 +436,9 @@
         if 'hw.optional.fma: 1' in result:
             config.available_features.add('fma3')
 
-# .debug_frame is not emitted for targeting Windows x64, aarch64/arm64, or AIX.
-if not re.match(r'^(x86_64|aarch64|arm64|powerpc|powerpc64).*-(windows-gnu|windows-msvc|aix)', config.target_triple):
+# .debug_frame is not emitted for targeting Windows x64, aarch64/arm64, AIX, or Apple Silicon Mac.
+if not re.match(r'^(x86_64|aarch64|arm64|powerpc|powerpc64).*-(windows-gnu|windows-msvc|aix)', config.target_triple) \
+    and not re.match(r'^arm64(e)?-apple-(macos|darwin)', config.target_triple):
     config.available_features.add('debug_frame')
 
 if config.have_libxar:
Index: llvm/test/MC/ELF/cfi-version.ll
===================================================================
--- llvm/test/MC/ELF/cfi-version.ll
+++ llvm/test/MC/ELF/cfi-version.ll
@@ -3,9 +3,6 @@
 ; RUN: %llc_dwarf %s -o - -dwarf-version 4 -filetype=obj | llvm-dwarfdump -v - | FileCheck %s --check-prefix=DWARF4
 ; RUN: %llc_dwarf %s -o - -dwarf-version 5 -filetype=obj | llvm-dwarfdump -v - | FileCheck %s --check-prefix=DWARF4
 
-; PR46647
-; XFAIL: arm64-apple
-
 ; .debug_frame is not emitted for targeting Windows x64, aarch64/arm64, or AIX.
 ; REQUIRES: debug_frame
 ; REQUIRES: object-emission


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134896.463972.patch
Type: text/x-patch
Size: 1441 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220929/d1254701/attachment.bin>


More information about the llvm-commits mailing list