[PATCH] D132523: Fixes to make arcanist compatible with php8.1 on Linux

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers requested changes to this revision.
nickdesaulniers added a comment.
This revision now requires changes to proceed.

The resulting patch fails to apply to arcanist for me. STR:

  $ cd llvm-project
  $ wget https://reviews.llvm.org/file/data/nrt6tovpa573cdwctpyc/PHID-FILE-kgufiuwoyczdbfqdezq5/D132523.diff
  $ git apply D132523.diff
  $ cd arcanist
  $ git am /android0/llvm-project/llvm/utils/phabricator/*.patch
  Applying: Fix PHP 8.1 incompatibility with `arc patch D<12345>`
  Applying: Fixes to make arcanist compatible with php8.1
  error: patch failed: src/error/PhutilErrorHandler.php:180
  error: src/error/PhutilErrorHandler.php: patch does not apply
  error: patch failed: src/lint/engine/ArcanistLintEngine.php:274
  error: src/lint/engine/ArcanistLintEngine.php: patch does not apply
  error: patch failed: src/lint/linter/ArcanistLinter.php:291
  error: src/lint/linter/ArcanistLinter.php: patch does not apply
  error: patch failed: src/moduleutils/PhutilLibraryMapBuilder.php:122
  error: src/moduleutils/PhutilLibraryMapBuilder.php: patch does not apply
  error: patch failed: src/object/Phobject.php:33
  error: src/object/Phobject.php: patch does not apply
  error: patch failed: src/parser/PhutilTypeSpec.php:76
  error: src/parser/PhutilTypeSpec.php: patch does not apply
  error: patch failed: src/unit/engine/phutil/PhutilTestCase.php:408
  error: src/unit/engine/phutil/PhutilTestCase.php: patch does not apply
  error: patch failed: src/utils/PhutilArray.php:29
  error: src/utils/PhutilArray.php: patch does not apply
  error: patch failed: src/utils/utils.php:2003
  error: src/utils/utils.php: patch does not apply
  error: patch failed: src/workflow/ArcanistWorkflow.php:728
  error: src/workflow/ArcanistWorkflow.php: patch does not apply
  Patch failed at 0002 Fixes to make arcanist compatible with php8.1
  hint: Use 'git am --show-current-patch=diff' to see the failed patch
  When you have resolved this problem, run "git am --continue".
  If you prefer to skip this patch, run "git am --skip" instead.
  To restore the original branch and stop patching, run "git am --abort".

This patch needs to be able to be applied on top of llvm/utils/phabricator/0001-Fix-PHP-8.1-incompatibility-with-arc-patch-D-12345.patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132523/new/

https://reviews.llvm.org/D132523