[PATCH] D134817: Remove the dependency between lib/DebugInfoDWARF and MC

[Shubham Sandeep Rastogi via Phabricator via llvm-commits]

rastogishubham added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:463-466
+  void dump(raw_ostream &OS, DIDumpOptions DumpOpts, bool IsEH,
+            std::function<Optional<StringRef>(uint64_t RegNum, bool isEH)>
+                Callback = nullptr,
+            unsigned IndentLevel = 1) const;
----------------
clayborg wrote:
> I would suggest we add the std::function callback to the DIDumpOptions since any DWARF that needs to dump something could be able to use the mapping of register number to register name. If "bool isEH" is also only used for this, maybe we can add that to DIDumpOptions as well.
I think this is a good suggestion and very do-able


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134817/new/

https://reviews.llvm.org/D134817