[PATCH] D134891: [AArch64][GlobalISel] Implement another combine for shufflevector->AArch64 G_EXT.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerLowering.cpp:376
+// sources of the shuffle are the same.
+static bool IsSingletonEXTMask(ArrayRef<int> M, LLT Ty, uint64_t &Imm) {
+  unsigned NumElts = Ty.getNumElements();
----------------
also document `Imm`?


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-ext.mir:271
+---
+name:            v2s64_singleton_ext
+alignment:       4
----------------
negative testcases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134891/new/

https://reviews.llvm.org/D134891