[PATCH] D116879: [llvm] Allow forced auto-vectorization of sincos() using libmvec

[Tim Schmielau via Phabricator via llvm-commits]

tim.schmielau added inline comments.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2229
+          // No pointer arguments: safe to vectorize.
           continue;
+        }
----------------
RKSimon wrote:
> I'm not sure this will work well once we want to handle sincos(<2 x double>, <2 x double>*, <2 x double>*) style patterns as well.
It is indeed only meant as a stopgap solution - don't vectorize any function with pointer arguments unless the user has asserted it is safe to do so. 
How would your pattern cause an issue if the user has already asserted it is safe to vectorize?

(On an unrelated note I should probably `recordAnalysis()` though when rejecting vectorization.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116879/new/

https://reviews.llvm.org/D116879