[PATCH] D134876: [ValueTracking] Fix CannotBeOrderedLessThanZero() for fdiv (PR58046)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 29 08:00:41 PDT 2022


spatel accepted this revision.
spatel added a comment.

LGTM



================
Comment at: llvm/test/Transforms/InstSimplify/floating-point-compare.ll:1002
 
-; FIXME: Miscompile.
 define i1 @pr58046(i64 %arg) {
----------------
This wasn't just wrong...it was really, really wrong. :)
https://alive2.llvm.org/ce/z/p4D5Bo

Worth a TODO; some missing analysis of int-to-FP casts?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134876/new/

https://reviews.llvm.org/D134876



More information about the llvm-commits mailing list