[PATCH] D125779: [llvm-debuginfo-analyzer] 04 - Locations and ranges

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/lib/DebugInfo/LogicalView/Core/LVRange.cpp:118
+
+// Find the associated Scope for the given ranges values.
+bool LVRange::findEntry(LVAddress LowerAddress, LVAddress UpperAddress) const {
----------------
probinson wrote:
> This comment does not describe what the method does, from the caller's perspective.  Also maybe should be named `hasEntry` instead of `findEntry` 
Comment changed to:
`// True if the range addresses contain the pair [LowerAddress, UpperAddress].`

Method renamed as `hasEntry`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125779/new/

https://reviews.llvm.org/D125779