[PATCH] D133943: [Utils] [WIP/RFC] Match function return type and other attributes on the definition in update_cc_test_checks

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

I have also wanted this in the past, and I don't think the church should be too bad since many tests don't use this flag and if they do it will only affect a few lines without any knock on effects.



================
Comment at: llvm/utils/UpdateTestChecks/common.py:540
       attrs = m.group('attrs') if self._check_attributes else ''
+      fundef_attrs_and_ret = m.group('fundef_attrs_and_ret') if self._record_args else ''
       # Determine if we print arguments, the opening brace, or nothing after the
----------------
How about 'funcdef'? I initially read this as being related to 'undef'.


================
Comment at: llvm/utils/update_test_checks.py:179
                                func_name, args.preserve_names, args.function_signature,
-                               global_vars_seen_dict,
+                               False, global_vars_seen_dict,
                                is_filtered=builder.is_filtered())
----------------
Why is this hardcoded to false, shouldn't it match the cc test checks version and use args.function_signature?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133943/new/

https://reviews.llvm.org/D133943