[PATCH] D134862: [AMDGPU][GISel] Update `isCanonicalized`

Thu Sep 29 05:56:33 PDT 2022

arsenm added a comment.

In D134862#3823579 <https://reviews.llvm.org/D134862#3823579>, @Pierre-vh wrote:

> I'm not sure I understand, which intrinsics need to be handled? The ones in INTRINSIC_WO_CHAIN in the DAG version?
> And what are the opcodes you're talking about? Things like CVT_F32?

Some of them are obscured by custom nodes in the DAG. Some examples are AMDGPUISD::FMAD_FTZ, AMDGPUISD::RCP (corresponding to llvm.amdgcn.rcp), and the cases in INTRINSIC_WO_CHAIN. Plus this is missing a number of the generic opcodes like G_FSQRT and G_FFLOOR

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134862/new/

https://reviews.llvm.org/D134862