[PATCH] D134862: [AMDGPU][GISel] Update `isCanonicalized`

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 29 05:43:55 PDT 2022


arsenm accepted this revision.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:10217-10218
   default:
     return denormalsEnabledForType(MRI.getType(Reg), MF) &&
            isKnownNeverSNaN(Reg, MRI);
   }
----------------
I just realized this is broken since it was copied from the DAG with FP value types. In another patch can you explicitly handle the custom intrinsics?

Plus this isn't handling some of the less common generic opcodes, like all the different rounding functions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134862/new/

https://reviews.llvm.org/D134862



More information about the llvm-commits mailing list