[PATCH] D134798: [LoongArch] Do not assert value type in isFPImmLegal

[Gong LingQin via Phabricator via llvm-commits]

gonglingqin added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:1813
                                            bool ForCodeSize) const {
-  assert((VT == MVT::f32 || VT == MVT::f64) && "Unexpected VT");
-
----------------
xen0n wrote:
> Thinking about it harder, do we want to inspect the element type of vectors and ensure corresponding ISA extension is present? In which case another similar assert is needed/better.
Thanks for the suggestion, I will add comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134798/new/

https://reviews.llvm.org/D134798