[PATCH] D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection
Pierre van Houtryve via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 29 04:02:16 PDT 2022
Pierre-vh updated this revision to Diff 463841.
Pierre-vh added a comment.
Rebase on tree that includes D134870 <https://reviews.llvm.org/D134870>.
All big regressions have been addressed, there's still a few minor differences between the DAG/GISel variants but I think they're not critical (I'll still look at them but please review in the meantime)
-> v_mad_mixhi_f16_f16lo_f16lo_f16lo_undeflo_clamp_precvt
-> weird use of shl but it's just one extra inst
-> v_mad_mixhi_f16_f16lo_f16lo_f16lo_intpack
-> constant rematerialization issue
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134354/new/
https://reviews.llvm.org/D134354
Files:
llvm/lib/Target/AMDGPU/AMDGPUGISel.td
llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
llvm/lib/Target/AMDGPU/VOP3PInstructions.td
llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-add-ext-fma.ll
llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-add-ext-mul.ll
llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-sub-ext-mul.ll
llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-sub-ext-neg-mul.ll
llvm/test/CodeGen/AMDGPU/mad-mix-hi.ll
llvm/test/CodeGen/AMDGPU/mad-mix-lo.ll
llvm/test/CodeGen/AMDGPU/mad-mix.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134354.463841.patch
Type: text/x-patch
Size: 285825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220929/9c1a23b6/attachment-0001.bin>
More information about the llvm-commits
mailing list