[PATCH] D131830: Clang Support for taskwait nowait clause

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5215-5216
   buildDependences(S, Data);
+  if (S.hasClausesOfKind<OMPNowaitClause>())
+    Data.HasNowaitClause = S.hasClausesOfKind<OMPNowaitClause>();
   CGM.getOpenMPRuntime().emitTaskwaitCall(*this, S.getBeginLoc(), Data);
----------------
No need for if here, just
```
Data.HasNowaitClause = S.hasClausesOfKind<OMPNowaitClause>();
```


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1418
 
+  int OpenMPVer;
 public:
----------------
int OpenMPVersion = 0?


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1421
+  /// Methods for OpenMPVer
+  int getOpenMPVer() { return OpenMPVer; }
+
----------------
int getOpenMPVersion() const {return OpenMPVersion; }
Plus, do you really need an OpenMP version check here? Just call the new function always


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131830/new/

https://reviews.llvm.org/D131830