[PATCH] D134211: [LV] Create createInductionResumeValue helper.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3179
+    for (BasicBlock *BB : BypassBlocks)
+    BCResumeVal->addIncoming(II.getStartValue(), BB);
 
----------------
Ayal wrote:
> nit: indent?
Yes, it looks like clang-format-diff doesn't handle formatting here properly for some reason. Will fix manually.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3193
+           "Inconsistent information about additional bypass.");
+    DenseMap<const InductionDescriptor *, Value *> ResumeValues;
+    // We are going to resume the execution of the scalar loop.
----------------
Ayal wrote:
> Probably meant to collect all BCResumeVals created and return them, but is currently dead code - better leave for subsequent patch and out of this refactoring patch?
This was left over from an earlier version, removed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134211/new/

https://reviews.llvm.org/D134211