[PATCH] D134854: [DAG] Update `isKnownNeverNaN` for `FMA/FMAD`

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 29 02:01:29 PDT 2022


foad added a comment.

In D134854#3823109 <https://reviews.llvm.org/D134854#3823109>, @Pierre-vh wrote:

> In D134854#3823061 <https://reviews.llvm.org/D134854#3823061>, @foad wrote:
>
>> Code change looks good. Is it possible to add a test as described in https://reviews.llvm.org/D50804#1202429?
>
> Do you mean we need the same test but in AMDGPU, or does the test need to be changed as well?

The test added in D50804 <https://reviews.llvm.org/D50804> was for fadd and fmul. I'm suggesting you could extend it now to cover fma and fmad as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134854/new/

https://reviews.llvm.org/D134854



More information about the llvm-commits mailing list