[PATCH] D134798: [LoongArch] Do not assert value type in isFPImmLegal

[Gong LingQin via Phabricator via llvm-commits]

gonglingqin added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/vector-fp-imm.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc --mtriple=loongarch32 -mattr=+f,-d < %s | FileCheck %s --check-prefix=LA32F
+; RUN: llc --mtriple=loongarch32 -mattr=+d < %s | FileCheck %s --check-prefix=LA32D
----------------
xen0n wrote:
> double dash
Thanks, I will change it.


================
Comment at: llvm/test/CodeGen/LoongArch/vector-fp-imm.ll:7
+
+;; TODO: Merge the offset of address calculation into the offset field of instructions.
+
----------------
xen0n wrote:
> What part of the expected output does this comment refer to? I can only see the offsets like 4 8 or 12 nicely placed inside the `f{ld,st}`'s already...
For line 142-143 of this file, the expected output is `fld.s $fa0, $a2, %pc_lo12(.LCPI1_0)`.  After the functionality is complete, similar scenarios can be optimized by adding a backend pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134798/new/

https://reviews.llvm.org/D134798