[lld] a98cbf0 - [ELF] Remove unused Symbol::getSymbolSize. NFC

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 14:32:35 PDT 2022


Author: Fangrui Song
Date: 2022-09-28T14:32:26-07:00
New Revision: a98cbf01fa306d815e4d594daece596daedd0999

URL: https://github.com/llvm/llvm-project/commit/a98cbf01fa306d815e4d594daece596daedd0999
DIFF: https://github.com/llvm/llvm-project/commit/a98cbf01fa306d815e4d594daece596daedd0999.diff

LOG: [ELF] Remove unused Symbol::getSymbolSize. NFC

Added: 
    

Modified: 
    lld/ELF/Symbols.h

Removed: 
    


################################################################################
diff  --git a/lld/ELF/Symbols.h b/lld/ELF/Symbols.h
index 2f6476a3314a..aa7ad4d425e6 100644
--- a/lld/ELF/Symbols.h
+++ b/lld/ELF/Symbols.h
@@ -259,8 +259,6 @@ class Symbol {
 
   bool shouldReplace(const Defined &other) const;
 
-  inline size_t getSymbolSize() const;
-
 protected:
   Symbol(Kind k, InputFile *file, StringRef name, uint8_t binding,
          uint8_t stOther, uint8_t type)
@@ -552,24 +550,6 @@ union SymbolUnion {
   alignas(LazyObject) char e[sizeof(LazyObject)];
 };
 
-size_t Symbol::getSymbolSize() const {
-  switch (kind()) {
-  case CommonKind:
-    return sizeof(CommonSymbol);
-  case DefinedKind:
-    return sizeof(Defined);
-  case LazyObjectKind:
-    return sizeof(LazyObject);
-  case SharedKind:
-    return sizeof(SharedSymbol);
-  case UndefinedKind:
-    return sizeof(Undefined);
-  case PlaceholderKind:
-    return sizeof(Symbol);
-  }
-  llvm_unreachable("unknown symbol kind");
-}
-
 template <typename... T> Defined *makeDefined(T &&...args) {
   auto *sym = new (reinterpret_cast<Defined *>(
       getSpecificAllocSingleton<SymbolUnion>().Allocate()))


        


More information about the llvm-commits mailing list