[PATCH] D130466: [LICM] - Add option to allow data races

[Shubham Narlawar via Phabricator via llvm-commits]

gsocshubham updated this revision to Diff 463654.
gsocshubham added a comment.

Address all the review comments.

1. Add 2 RUN lines in LIT tests with prefixes - LICM-TMS and LICM-NO-TMS where TMS stands for Thread Model Single

2. Add a minimal test for globals where store promotion will happen only if flag is set and load promotion happens irrespective of the flag.

-> "promote-sink-store-global.ll"

3. Add a minimal test for constant globals where store promotion will not happen irrespective of the flag.

-> "promote-sink-store-constant-global.ll"

4. Add a minimal test for function argument where store promotion will not happen.

-> "promote-sink-store-arg.ll"

5. Add a minimal test for alloca that is captured where store promotion will happen.

-> "promote-sink-store-capture.ll"

6. At last there is a testcase named - "promote-sink-store.ll" which is the testcase attached in original bug description from github - https://github.com/llvm/llvm-project/issues/50537


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130466/new/

https://reviews.llvm.org/D130466

Files:
  llvm/include/llvm/Analysis/TargetTransformInfo.h
  llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
  llvm/include/llvm/CodeGen/BasicTTIImpl.h
  llvm/include/llvm/Transforms/Utils/LoopUtils.h
  llvm/lib/Analysis/TargetTransformInfo.cpp
  llvm/lib/Transforms/Scalar/LICM.cpp
  llvm/test/Transforms/LICM/promote-sink-store-arg.ll
  llvm/test/Transforms/LICM/promote-sink-store-capture.ll
  llvm/test/Transforms/LICM/promote-sink-store-constant-global.ll
  llvm/test/Transforms/LICM/promote-sink-store-global.ll
  llvm/test/Transforms/LICM/promote-sink-store.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130466.463654.patch
Type: text/x-patch
Size: 43695 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220928/87876ff6/attachment.bin>