[PATCH] D134817: Remove the dependency between lib/DebugInfoDWARF and MC

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:167
+            std::function<Optional<StringRef>(uint64_t RegNum, bool isEH)>
+                Callback = nullptr) const;
 
----------------
aprantl wrote:
> I am mildly surprised that `= nullptr` works. Should the default argument be a lambda or static function that returns `llvm::None`?
Ah I see, there's a constructor for std::function that explicitly takes a nullptr and you are checking the operator bool() before calling it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134817/new/

https://reviews.llvm.org/D134817