[PATCH] D134166: [MLGO] Add per-instruction MBB frequencies to regalloc dev features

[Jacob Hegna via Phabricator via llvm-commits]

jacobhegna added a comment.

lgtm, this will be really useful!

just so I understand, mbb_frequencies will be of shape (1, 100) and if there are less than 100 mbbs, the rest of the entries will be 0? and mbb_mapping will of shape (1, 300) and contains the indices of the mbb for each instruction?

just a small question/nit: why use a one-hot encoding for the instruction opcode features but an index encoding for the frequencies?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134166/new/

https://reviews.llvm.org/D134166