[PATCH] D134799: [RISCV][CodeGen][NFC] Add fixed vector type test cases for llvm.round.*

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 09:49:29 PDT 2022


craig.topper added a comment.

In D134799#3821287 <https://reviews.llvm.org/D134799#3821287>, @eopXD wrote:

> In D134799#3821276 <https://reviews.llvm.org/D134799#3821276>, @craig.topper wrote:
>
>> What was wrong with the tests in fixed-vectors-fp.ll other than it not covering as many types?
>
> Sorry that I didn't notice test cases where collected under `fixed-vectors-fp.ll`. Do you recommend to revert this commit?

Don't revert it. We should probably remove the redundant round tests from fixed-vectors-fp.ll


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134799/new/

https://reviews.llvm.org/D134799



More information about the llvm-commits mailing list