[PATCH] D133283: [DirectX backend] Support global ctor for DXILBitcodeWriter.

[Chris Bieneman via Phabricator via llvm-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

One small nit, otherwise looks good.



================
Comment at: llvm/lib/Target/DirectX/PointerTypeAnalysis.cpp:109
     if (ArgTy->isOpaquePointerTy()) {
-      TypedPointerType *NewTy = classifyPointerType(&A);
-      Map[&A] = NewTy;
+      Type *NewTy = classifyPointerType(&A, Map);
       ArgTy = NewTy;
----------------
nit: Why not just assign this to `ArgTy`? Temporary seems unnecessary now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133283/new/

https://reviews.llvm.org/D133283