[PATCH] D134427: [Verifier] Allow undef token argument to llvm.experimental.gc.result

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 06:31:39 PDT 2022


mkazantsev added inline comments.


================
Comment at: llvm/test/Verifier/gc_result_token.ll:8
+entry:
+    br i1 true, label %label_1, label %label_2
+
----------------
nikic wrote:
> Branch is unnecessary here -- you want label_2 to be unreachable in the CFG, not just dynamically dead.
No, this is fine. If a pass is unable to modify CFG, it still has a right to replace operands with undef under if(false).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134427/new/

https://reviews.llvm.org/D134427



More information about the llvm-commits mailing list