[PATCH] D134439: [StructurizeCFG] Remove imposible case, associated test, and replace by assert
Ruiling, Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 28 06:13:31 PDT 2022
ruiling added inline comments.
================
Comment at: llvm/test/Transforms/StructurizeCFG/infinite-loop.ll:7
+
+define void @infinite_loop_undef(i32 addrspace(1)* %out) {
+; CHECK-LABEL: @infinite_loop_undef(
----------------
I think you can just remove this one, we don't need to test against 'br undef'. There has been discussion to remove 'br undef' in test, see https://discourse.llvm.org/t/please-dont-use-br-undef-in-tests-aka-please-avoid-test-cases-with-ub/63115. Other parts LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134439/new/
https://reviews.llvm.org/D134439
More information about the llvm-commits
mailing list