[PATCH] D134794: [lld-macho] Do not error out on dead stripped duplicate symbols

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 04:27:30 PDT 2022


thakis added a comment.

> it's far better to align with ld64's behavior to be closer as a drop-in replacement

FWIW, I don't agree with this argument, and our doc listing intentional differences doesn't either. (Not deduping strings by default is a big difference and we're stricter in various other areas too.)

I don't have a problem with the patch itself (people who want the stricter behavior can not dead_strip, and most projects probably don't do dead stripping in debug builds), but you need to come up with a better justification: why is fixing this problem harder than others you have to fix when you want to use lld?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134794/new/

https://reviews.llvm.org/D134794



More information about the llvm-commits mailing list