[PATCH] D132978: [CodeGen] Using ZExt for extractelement indices.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 00:29:09 PDT 2022


frasercrmck added a subscriber: reames.
frasercrmck added a comment.

In D132978#3817541 <https://reviews.llvm.org/D132978#3817541>, @Petar.Avramovic wrote:

> Other type of regression is when i32 (marked as signed argument) has to be zero-extended to i64 (and with mask), before it used to be a copy. Considering langref changes it is probably more correct to mark index arguments as zeroext (index will be copied again no code size regression). But this should be checked with people who know more about specific targets.

For RISCV I think that the indices should indeed be marked `zext`. Testing `sext` doesn't get us a whole lot IMO. @craig.topper, @reames?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132978/new/

https://reviews.llvm.org/D132978



More information about the llvm-commits mailing list