[PATCH] D134793: [AMDGPU] Update `mad-mix*` CodeGen tests

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 27 23:50:35 PDT 2022


Pierre-vh created this revision.
Pierre-vh added a reviewer: arsenm.
Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
Pierre-vh requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

- Use `fneg %a` instead of `fsub -0.0, %a`
  - This is for D134354 <https://reviews.llvm.org/D134354> as we don't currently support folding `fsub -0.0, %a` into `fneg` on GISel. Also, `fneg` is the canonical way to do the negation.
- Switch to `update_llc_test_checks`-generated tests.
  - Better test coverage
  - Easier to update
  - Easier to see changes in future diffs
- Remove unnecessary CL arguments in RUN lines

Motive for the patch: Preparation for D134354 <https://reviews.llvm.org/D134354> - we would like to
put GISel tests in this file as well. Fixing the lack of `fneg` and
switching to generated testing makes it much easier.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134793

Files:
  llvm/test/CodeGen/AMDGPU/mad-mix-hi.ll
  llvm/test/CodeGen/AMDGPU/mad-mix-lo.ll
  llvm/test/CodeGen/AMDGPU/mad-mix.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134793.463443.patch
Type: text/x-patch
Size: 133701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220928/b74201d8/attachment.bin>


More information about the llvm-commits mailing list