[PATCH] D134710: [LoongArch] Set correct encodings for DWARF exception handling

Tue Sep 27 21:36:06 PDT 2022

xry111 added a comment.

In D134710#3819859 <https://reviews.llvm.org/D134710#3819859>, @xen0n wrote:

> LGTM but I haven't cross-checked with gcc.

https://gcc.gnu.org/git?p=gcc.git;a=blob;f=gcc/config/loongarch/loongarch.h#l1133:

  #ifdef HAVE_AS_EH_FRAME_PCREL_ENCODING_SUPPORT
  #define ASM_PREFERRED_EH_DATA_FORMAT(CODE, GLOBAL) \
    (((GLOBAL) ? DW_EH_PE_indirect : 0) | DW_EH_PE_pcrel | DW_EH_PE_sdata4)
  #else
  #define ASM_PREFERRED_EH_DATA_FORMAT(CODE, GLOBAL) \
    (((GLOBAL) ? DW_EH_PE_indirect : 0) | DW_EH_PE_absptr)
  #endif

The `ifdef` is just for old GNU assemblers, we don't need to care about it because normally LLVM doesn't use an external assembler.  I'm not sure about the difference with `DW_EH_PE_indirect` though (I know literally, nothing about debug symbols).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134710/new/

https://reviews.llvm.org/D134710