[PATCH] D134439: [StructurizeCFG] Remove imposible case, associated test, and replace by assert

Tue Sep 27 19:43:27 PDT 2022

ruiling accepted this revision.
ruiling added a comment.
This revision is now accepted and ready to land.

In D134439#3818081 <https://reviews.llvm.org/D134439#3818081>, @jmmartinez wrote:

> In D134439#3810796 <https://reviews.llvm.org/D134439#3810796>, @ruiling wrote:
>
>> I think it should be ok to remove the code, but I would rather we keep the tests, the test is hitting the limitation of StructurizeCFG. The test contains infinite loop in its CFG. Maybe we can update the comment in the test to say this, and see whether we could solve this problem later.
>
> Whay do you think about removing this test and introducing a separate `infinite-loop.ll` test ? I'd prefer a test that matches what we expect `StructurizeCFG` to do on an infinite loop (in this particular case, nothing) than the current test.

sounds good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134439/new/

https://reviews.llvm.org/D134439