[PATCH] D134769: [ASan] Workaround for a performance problem in StackSafetyAnalysis pass.

[Kirill Stoimenov via Phabricator via llvm-commits]

kstoimenov added inline comments.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:62
 
+static cl::opt<size_t> StackSafetyMaxAllocas("stack-safety-max-allocas",
+                                             cl::init(250), cl::Hidden);
----------------
vitalybuka wrote:
> int is enough
Yeah, but it produces a warning when I compare it with .size(). 


================
Comment at: llvm/test/Instrumentation/AddressSanitizer/asan-stack-safety.ll:3
 
-; RUN: opt < %s -S -asan-instrumentation-with-call-threshold=0 -passes='asan-pipeline' -asan-use-stack-safety=0 -o - | FileCheck %s --implicit-check-not="call {{.*}} @__asan_{{load|store|stack}}" --check-prefixes=CHECK,NOSAFETY
-; RUN: opt < %s -S -asan-instrumentation-with-call-threshold=0 -passes='asan-pipeline' -asan-use-stack-safety=1 -o - | FileCheck %s --implicit-check-not="call {{.*}} @__asan_{{load|store|stack}}"
+; RUN: opt < %s -S -asan-instrumentation-with-call-threshold=0 -passes='asan-pipeline' -asan-use-stack-safety=0 -o - | \
+; RUN:   FileCheck %s --implicit-check-not="call {{.*}} @__asan_{{load|store|stack}}" --check-prefixes=CHECK,NOSAFETY
----------------
vitalybuka wrote:
> don't break lines, line len is not enforced in tests
I prefer that for readability. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134769/new/

https://reviews.llvm.org/D134769