[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Basic/Targets/LoongArch.cpp:103
+      Info.setAllowsMemory();
+      Name++; // Skip over 'Z'.
+      return true;
----------------
`++Name`


================
Comment at: clang/lib/Basic/Targets/LoongArch.cpp:117
+    // parsing.
+    R = std::string("^") + std::string(Constraint, 2);
+    Constraint++;
----------------
First `std::string` can be omitted


================
Comment at: clang/lib/Basic/Targets/LoongArch.cpp:118
+    R = std::string("^") + std::string(Constraint, 2);
+    Constraint++;
+    break;
----------------
pre-increment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134638/new/

https://reviews.llvm.org/D134638