[PATCH] D134682: [DirectX] Generate `dx.resources` metadata entry

Xiang Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 27 14:13:41 PDT 2022


python3kgae added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILResource.cpp:122-129
+  Entries[0] = ConstantAsMetadata::get(B.getInt32(ID));
+  Entries[1] = ConstantAsMetadata::get(GV);
+  Entries[2] = MDString::get(Ctx, Name);
+  Entries[3] = ConstantAsMetadata::get(B.getInt32(Space));
+  Entries[4] = ConstantAsMetadata::get(B.getInt32(LowerBound));
+  Entries[5] = ConstantAsMetadata::get(B.getInt32(RangeSize));
+  Entries[6] =
----------------
This could be in ResourceBase.
Refactoring when we got other resource classes too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134682/new/

https://reviews.llvm.org/D134682



More information about the llvm-commits mailing list