[PATCH] D134759: [VP][RISCV] Add vp.floor, vp.round, vp.roundeven and their RISC-V support

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 27 13:26:53 PDT 2022


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM other than the node about the extra slash in the comment.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1969
+// Expand vector FTRUNC, FCEIL, FFLOOR, FROUND, VP_FCEIL, VP_FFLOOR, VP_FROUND
+// and VP_FROUNDEVEN by converting to the integer domain/ and back. Taking care
+// to avoid converting values that are nan or already correct.
----------------
Drop the extra slash after domain. Not sure where that came from.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134759/new/

https://reviews.llvm.org/D134759



More information about the llvm-commits mailing list