[PATCH] D134714: [AMDGPU] Make the uses_dynamic_stack field in the kernel descriptor and the metadata map specific to code object v5 and later

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

What's broken in the runtime? If it didn't read it before, how can this break something?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:420-421
 
-  if (CurrentProgramInfo.DynamicCallStack) {
+  if (AMDGPU::getAmdhsaCodeObjectVersion() >= 5 &&
+      CurrentProgramInfo.DynamicCallStack) {
     KernelCodeProperties |= amdhsa::KERNEL_CODE_PROPERTY_USES_DYNAMIC_STACK;
----------------
Swap order of checks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134714/new/

https://reviews.llvm.org/D134714