[PATCH] D134469: [DirectX] Add DXIL metadata `dx.shaderModel`

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILMetadata.cpp:68
+
+void dxil::createShaderModelMD(Module &M) {
+  NamedMDNode *Entry = M.getOrInsertNamedMetadata("dx.shaderModel");
----------------
beanz wrote:
> python3kgae wrote:
> > Shall we add "dx.version" in the function too since it is just shader model with offset on major.
> Yea, that’s probably fair. There is a possibility the two versions may not always be in sync, but we can cross that when we get there.
I'd like to have that come in through a separate metadata utility function just for code organization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134469/new/

https://reviews.llvm.org/D134469