[PATCH] D134429: [DebugInfo][LICM] Drop DebugLoc from IntrinsicInst when hoisting

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Well, yes, there are different scenarios for consumers of the line table.  Profilers really should care most about "why are we in this block" rather than "where exactly did this instruction come from" while someone using addr2line to try to track down a trapping instruction would really want the most accurate provenance possible.  Line info can't realistically meet all needs equally.  Until we get to a line table that can comfortably address all the needs, we have to make choices.
In this particular case, adding non-call-intrinsics to the set of instructions that are already handled a particular way seems like the most consistent behavior we can have, and consistency seems like a positive thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134429/new/

https://reviews.llvm.org/D134429