[PATCH] D134684: [LegalizeTypes][Mips][RISCV][SystemZ] Mask shift amounts in ExpandShiftWithUnknownAmountBit.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D134684#3818528 <https://reviews.llvm.org/D134684#3818528>, @efriedma wrote:

> If we're not allowed to use the libcall with out-of-bounds shift amounts at all, don't we need to unconditionally mask before we generate the libcall?  In general, we can speculate out-of-bounds shifts at the IR level; it doesn't make sense to special-case out-of-bounds shifts generated in SelectionDAG.

That's a good point. gcc doesn't appear to mask the call either. Maybe we only need to weaken the pre-condition comment on the function on compiler-rt?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134684/new/

https://reviews.llvm.org/D134684