[PATCH] D134376: [ModuleInliner] Add a cost-benefit-based priority

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

> a large internel benchmark yields performance comparable to the bottom-up inliner -- both in terms of the execution performance and .text* sizes.

This looks promising. The comparison is between `enable-module-inliner` on vs off, right? Do you plan to tune and open up module inliner for sample PGO and non-PGO cases where cost-benefit analysis isn't available yet?



================
Comment at: llvm/lib/Analysis/InlineOrder.cpp:34
+                          "Use inline cost priority."),
+               clEnumValN(InlinePriorityMode::OptRatio, "optratio",
+                          "Use cost-benefit ratio.")));
----------------
perhaps just name it "cost-benefit"? "ratio" can be confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134376/new/

https://reviews.llvm.org/D134376