[PATCH] D134586: [VP][RISCV] Add vp.ceil and RISC-V support

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 27 08:20:15 PDT 2022


frasercrmck added a comment.

In D134586#3818275 <https://reviews.llvm.org/D134586#3818275>, @craig.topper wrote:

> In D134586#3817430 <https://reviews.llvm.org/D134586#3817430>, @frasercrmck wrote:
>
>> Forgive me if I've missed something but you're adding support for widening and splitting in the legalizer without adding tests for that behaviour.
>
> There's a <vscale x 7 x double> <vscale x 16 x double>, <15 x double> and <32 x double> test. Does that cover it?

Yes, thanks. To my shame I didn't read through the whole tests before making that comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134586/new/

https://reviews.llvm.org/D134586



More information about the llvm-commits mailing list